Skip to content

chore: update dependencies to support workload identity federation#2517

Merged
bcoe merged 5 commits into
googleapis:masterfrom
bojeil-google:master
Feb 17, 2021
Merged

chore: update dependencies to support workload identity federation#2517
bcoe merged 5 commits into
googleapis:masterfrom
bojeil-google:master

Conversation

@bojeil-google

Copy link
Copy Markdown
Contributor

Bump up versions for:

  • google-auth-library to ^7.0.2
  • googleapis-common to ^5.0.1

The changes above are not sufficient as the BaseExternalAccountClient type is still missing in the generated APIs. As a result BaseExternalAccountClient was added to the API templates api-endpoint.njk and all the APIs were regenerated.
While we're at it, googleapis-common dependency in the generated APIs was updated to ^5.0.1.

Bump up versions for:
- `google-auth-library` to `^7.0.2`
- `googleapis-common` to `^5.0.1`

The changes above are not sufficient as the `BaseExternalAccountClient` type is still missing in the generated APIs. As a result `BaseExternalAccountClient` was added to the API templates `api-endpoint.njk` and all the APIs were regenerated.
While we're at it, `googleapis-common` dependency in the generated APIs was updated to `^5.0.1`.
@bojeil-google bojeil-google requested a review from a team February 17, 2021 03:23
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2021
@codecov

codecov Bot commented Feb 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2517 (b6c8021) into master (5646a65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2517   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files          11       11           
  Lines        1756     1756           
  Branches      123      103   -20     
=======================================
  Hits         1500     1500           
  Misses        256      256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5646a65...6064389. Read the comment docs.

@bojeil-google

Copy link
Copy Markdown
Contributor Author

@bcoe regarding this PR:

  • I only updated the templates file and ran npm run generate. All the apis file changes were auto-generated. (I didn't manually modify them).
  • Regarding the failing npm test, it seems to be due to the test environment running out of memory. I think a rerun could fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants