First, I rarely check preconditions.
Most methods assume they are passed good data,
and dispense with null checks and similar principles of good code hygiene
The
Magical Number Seven, Plus or Minus Two: Some Limits on Our Capacity for Pro‐
93
[Link]
cessing Information,” in the Psychological Review, Vol. 63, pp. 81–97
Enterprise Integration Patterns, by Gregor Hohpe and Bobby Woolf (Addison Wesley,
2004)
[Link]
4852 -
[2, "uniqueId", "ReserveNow", {"connectorId": 1, "expiryDate": "2024-03-
21T10:00:00.000Z", "idTag": "TAG123", "reservationId": 12345}]
1) when we discussed this task with Ionut - he said there is no need for new table
(for the links). he said all links are used in memory from the response - was this
incorrect?
- Yes, because when we call the getAccounts/getCards etc. we receive a Set of Data.
Later we call the balances/transactions based on the newly received set of
data(which have the links) + the set of data we have in the DB for that consentId
(without the links if we don't have them) - leading to a loss of data.
2) and even if needed why is this links table so big? so many columns? I would have
imagined 5,6 columns max
We will discuss cu Ionut,
3) In addition, I do not see the the bank table change, we said this definition can
be set on global level or per bank, also can be seen in the code but the change log
for it is missing
-The change log addition exists in commit: 18222c2, in common/db-scripts/change-
log/schema/[Link]
ocpp logging si connector cod ca sa apeleze altcv in spate