Fix: Harden PhpRedis against protocol errors#2872
Merged
Merged
Conversation
* Fix a double free when zipping keys and scores. * Instead of aborting with an assertion if elements != 2 just warn and return failure * Instead of crashing on `xclaim` reply shape issues, just return false
yatsukhnenko
approved these changes
Jun 15, 2026
| val = zval_get_tmp_string(z_value_p, &aux); | ||
|
|
||
| if (decode == SCORE_DECODE_INT && ZSTR_LEN(val) > 0) { | ||
| ZVAL_LONG(&z_sub, atoi(ZSTR_VAL(val)+1)); |
Member
Author
There was a problem hiding this comment.
Yes, I think because here we get :N\r\n
| if (decode == SCORE_DECODE_INT && ZSTR_LEN(val) > 0) { | ||
| ZVAL_LONG(&z_sub, atoi(ZSTR_VAL(val)+1)); | ||
| } else if (decode == SCORE_DECODE_DOUBLE) { | ||
| ZVAL_DOUBLE(&z_sub, atof(ZSTR_VAL(val))); |
Member
Author
There was a problem hiding this comment.
And here we just get <float>\r\nbecause in RESP2 it's a bulk reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xclaimreply shape issues, just return false