Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

chore(deps): update dependency gts to v1#68

Merged
callmehiphop merged 3 commits into
masterfrom
renovate/gts-1.x
May 3, 2019
Merged

chore(deps): update dependency gts to v1#68
callmehiphop merged 3 commits into
masterfrom
renovate/gts-1.x

Conversation

@renovate

@renovate renovate Bot commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change References
gts devDependencies major ^0.9.0 -> ^1.0.0 source

Release Notes

google/gts

v1.0.0

Compare Source

This release contains breaking changes. Picking up this update most likely will cause a breaking change in your module. Take care when picking up this update.

Breaking Changes

  • We have switched to prettier as the code formatting tool (#​259). gts run fix should migrate your code over to the new style 💅.
  • This release drops support for Node 6 which will reach end-of-life in April 2019 (#​256) 💀.
  • This release defaults to ES2017 as the TypeScript code generation target. This means that the generated code needs a minimum of Node 8 to run. On the plus side this means that generated code would use native implementation of ES2017 features (e.g. async/await) rather than using poly-fills 🧬. This change is most likely a breaking change for your module. You can override this setting by customizing your tsconfig.json however.
  • The tslint configuration has been updated to pick up changes in the Google style guide🧐.
  • Assumes that target projects are using TypeScript 3.x+ 🎯.

Other features

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
@callmehiphop callmehiphop added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2019
@renovate renovate Bot force-pushed the renovate/gts-1.x branch from 941a4ea to 2dd6fda Compare April 26, 2019 19:53
@codecov

codecov Bot commented Apr 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #68 into master will decrease coverage by 1.2%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   33.92%   32.72%   -1.21%     
==========================================
  Files           1        1              
  Lines          56       55       -1     
  Branches       18       18              
==========================================
- Hits           19       18       -1     
  Misses         34       34              
  Partials        3        3
Impacted Files Coverage Δ
src/index.ts 32.72% <42.85%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc4841...7ba0c3e. Read the comment docs.

@callmehiphop callmehiphop removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2019
@renovate renovate Bot force-pushed the renovate/gts-1.x branch from 2dd6fda to 0c09019 Compare April 29, 2019 22:21
@googlebot

googlebot commented Apr 30, 2019

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 30, 2019
@renovate

renovate Bot commented Apr 30, 2019

Copy link
Copy Markdown
Contributor Author

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 3, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@callmehiphop

callmehiphop commented May 3, 2019

Copy link
Copy Markdown
Contributor

@bcoe @JustinBeckwith 👋

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 3, 2019
@googlebot

googlebot commented May 3, 2019

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@callmehiphop callmehiphop merged commit 972b473 into master May 3, 2019
@renovate renovate Bot deleted the renovate/gts-1.x branch May 3, 2019 17:19
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@callmehiphop callmehiphop callmehiphop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@googlebot @callmehiphop @bcoe @kokoro-team @yoshi-automation