ref(node-core): Use @sentry/conventions#21494
Draft
mydea wants to merge 1 commit into
Draft
Conversation
Contributor
size-limit report 📦
|
3bbe4e5 to
a7ba254
Compare
625467a to
2a83a9f
Compare
dad366f to
ee14a78
Compare
Source span/attribute keys from `@sentry/conventions` as a regular dependency (externalized at build time, resolved at runtime). No functional change. Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the repo's `node` moduleResolution type builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ee14a78 to
1c0a240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches
@sentry/node-coreto source span/attribute keys from@sentry/conventions, added as a regular runtimedependencyand externalized at build time (resolved at runtime by the consumer's installed copy). No functional change — the attribute values are identical.Also maps the
@sentry/conventions/attributessubpath inpackages/typescript/tsconfig.jsonfor the repo'snodemoduleResolution type builds.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982