xdsclient: send Node proto only on first discovery request on ADS stream#6078
Merged
easwars merged 2 commits intoMar 3, 2023
Merged
Conversation
arvindbr8
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the xdsclient transport to send the node proto only on the first request on the stream. If the stream breaks, the node proto will be sent on the first request of subsequent streams as well.
Other changes in this PR (mostly testing related)
testResourceWatchertype fromauthority_test.gointoxds/internal/testutilspackage, and export it.authority_test.goto use the newTestResourceWatchertype exported above.fakeserver.Serverto be started with anet.Listenerprovided by the test.Fixes #5668.
RELEASE NOTES: