Skip to content

fix(v-bind-style): only change kebabCase to camelCase#2410

Merged
ota-meshi merged 2 commits into
vuejs:masterfrom
waynzh:feature/camelcase
Feb 27, 2024
Merged

fix(v-bind-style): only change kebabCase to camelCase#2410
ota-meshi merged 2 commits into
vuejs:masterfrom
waynzh:feature/camelcase

Conversation

@waynzh

@waynzh waynzh commented Feb 27, 2024

Copy link
Copy Markdown
Member

fix #2409

@FloEdelmann FloEdelmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have one suggestion for an additional test case, otherwise this looks good to me already 🙂

Comment thread tests/lib/rules/v-bind-style.js

@FloEdelmann FloEdelmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@ota-meshi ota-meshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sameNameShorthand from vue/v-bind-style confuses hyphens with underscores

3 participants