Skip to content

fix: prevent prototype pollution via __proto__ #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 3 commits into from
Apr 1, 2026
+7 −1
Merged

fix: prevent prototype pollution via __proto__ #156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70aa604
fix: avoids prototype pollution
kricsleo Apr 1, 2026
0493ab8
Merge branch 'main' into fix/proto-pollution
pi0 Apr 1, 2026
5767f6f
Merge branch 'main' into fix/proto-pollution
pi0 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: avoids prototype pollution
  • Loading branch information
@kricsleo
kricsleo committed Apr 1, 2026
commit 70aa6044f5a762c9738eaf24d9667189cd78b611
2 changes: 1 addition & 1 deletion src/defu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function _defu<T>(
return _defu(baseObject, {}, namespace, merger);
}

const object = Object.assign({}, defaults);
const object = { ...defaults };

for (const key in baseObject) {
if (key === "__proto__" || key === "constructor") {
Expand Down
6 changes: 6 additions & 0 deletions test/defu.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ describe("defu", () => {
defu({}, payload);
defu(payload, {});
defu(payload, payload);

const malicious = JSON.parse('{"__proto__":{"isAdmin":true}}');
const result = defu(malicious, { isAdmin: false });

expect(result.isAdmin).toBe(false);

// @ts-ignore
expect({}.isAdmin).toBe(undefined);
});
Expand Down
Loading