GH-5280: Include job execution details in JobExecutionAlreadyRunningException#5424
Open
won-seoop wants to merge 1 commit into
Open
Conversation
…AlreadyRunningException The exception message previously included the JobInstance details (which identifies the job by name and parameters), while the exception type and its description clearly indicate that a specific *execution* is already running. Replacing `jobInstance` with `execution` in the message makes the output immediately actionable: it now shows the execution id, status, start time, and other execution-level attributes instead of repeating instance-level information that is already clear from context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5280.
When
TaskExecutorJobLauncherdetects that a job execution is already running, it throwsJobExecutionAlreadyRunningException. Previously the exception message included theJobInstancedetails:Wait, no. The old message was:
This only shows the job instance details (name and parameters), not which execution is running. Switching to the running
executionobject makes the message immediately useful, showing the execution id, start time, status, and other execution-level details.Before:
After:
Test plan
TaskExecutorJobLauncherTestsandJobRestartIntegrationTestscontinue to pass.🤖 Generated with Claude Code