GH-4551: Add foreign key index recommendations to schema appendix#5419
Open
won-seoop wants to merge 1 commit into
Open
GH-4551: Add foreign key index recommendations to schema appendix#5419won-seoop wants to merge 1 commit into
won-seoop wants to merge 1 commit into
Conversation
…ma appendix Expands the "Recommendations for Indexing Metadata Tables" section with a new "Foreign Key Columns" subsection that lists the FK columns in each Spring Batch metadata table as candidates for additional indexes. The issue points out that the existing recommendations only covered WHERE-clause columns while omitting FK columns. On databases like PostgreSQL that do not automatically index FK columns (unlike MySQL or Oracle), unindexed FK columns cause performance problems on the frequent JOIN queries issued by Spring Batch's DAO layer. Also adds a NOTE directing users to their database's documentation for detecting unindexed foreign keys, with a link to the PostgreSQL query referenced in the issue. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #4551.
Extends the Recommendations for Indexing Metadata Tables section in
schema-appendix.adocwith a new Foreign Key Columns subsection.Changes
The existing table lists WHERE-clause columns as indexing candidates but does not mention foreign key columns. On databases that do not automatically create indexes for FK columns (notably PostgreSQL, as mentioned in the issue), this leads to unindexed FK lookups on the frequent JOIN queries that Spring Batch issues via its DAO layer.
New subsection includes:
Test plan
🤖 Generated with Claude Code