fix(button-group): support accessibilityLabel and accessibilityHint for custom buttons#4030
Open
ashimraja wants to merge 1 commit into
Open
Conversation
…ort for custom buttons (react-native-elements#3196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Accessibility support for ButtonGroup
Problem
Custom buttons passed to ButtonGroup do not propagate accessibilityLabel and accessibilityHint, so screen readers (TalkBack/VoiceOver) do not announce them.
Solution
• Extracted accessibility props from React elements
• Passed them to the underlying Pressable component
Testing
• Tested on Android emulator with TalkBack
• Verified correct announcement of label and hint
Example:
Checklist
Type of Change
Testing