Skip to content

src: update crypto objects to use DictionaryTemplate#59942

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/crypto-use-dictionarytemplate
Sep 22, 2025
Merged

src: update crypto objects to use DictionaryTemplate#59942
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/crypto-use-dictionarytemplate

Conversation

@jasnell

@jasnell jasnell commented Sep 20, 2025

Copy link
Copy Markdown
Member

More v8::DictionaryTemplate use

@jasnell jasnell requested review from addaleax and anonrig September 20, 2025 02:50
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 20, 2025
@codecov

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 21, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit 327e175 into nodejs:main Sep 22, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 327e175

@aduh95 aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants