feat: release theme flash fix#9014
Open
wangsijie wants to merge 1 commit into
Open
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/release-theme-flash-fix.md | 📉 -342 Bytes |
| packages/account/src/Providers/PageContextProvider/index.tsx | 📉 -584 Bytes |
| packages/core/src/tenants/Tenant.ts | 📉 -49 Bytes |
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the previously gated “theme flash prevention” work for release by enabling Account Center SSR theme injection by default and ensuring the Account Center SPA does not override the initial theme while settings are still loading.
Changes:
- Always mount
koaAccountCenterSsr()before serving the Account Center SPA. - Remove the dev-feature gate around Account Center theme stabilization logic (early-return while settings load).
- Add a release changeset covering the theme flash prevention rollout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/tenants/Tenant.ts | Enables Account Center SSR theme data injection middleware unconditionally. |
| packages/account/src/Providers/PageContextProvider/index.tsx | Makes theme stabilization behavior always-on by removing the dev-feature gate and returning early while settings load. |
| .changeset/release-theme-flash-fix.md | Adds release notes and version bumps for the theme flash prevention rollout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '/' + UserApps.AccountCenter, | ||
| compose([ | ||
| ...(EnvSet.values.isDevFeaturesEnabled ? [koaAccountCenterSsr(libraries)] : []), | ||
| koaAccountCenterSsr(libraries), |
simeng-li
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Tested locally