Expand ITaskItem<T> binding to support arbitrary value types (int, bool, etc.)#13974
Draft
baronfel wants to merge 1 commit into
Draft
Expand ITaskItem<T> binding to support arbitrary value types (int, bool, etc.)#13974baronfel wants to merge 1 commit into
baronfel wants to merge 1 commit into
Conversation
066020c to
a06f9e6
Compare
676b7c9 to
1460831
Compare
a06f9e6 to
7531acb
Compare
Extends the engine to accept ITaskItem<T> where T is any value type (int, bool, long, etc.) in addition to path-like types. Uses ValueTypeParser for parsing and formatting. Also adds corresponding unit tests for ITaskItem<int> binding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> # Conflicts: # src/Shared/TaskItemTypeHelper.cs
1460831 to
2e0738d
Compare
Member
Author
|
Note: we don't want this to be any value type - consult w/ @rainersigwald on the allowed subset (likely bool, char (??), enum, etc) and consider loosening at a later date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the ITaskItem engine support introduced in #13971 to handle arbitrary value types (int, bool, long, etc.) in addition to path-like types. Uses ValueTypeParser for consistent parsing and formatting of value types.
Changes
Stacked on
/cc @baronfel