Skip to content

[PM-38393]: add debug-disable-self-host-premium-check feature flag#7805

Open
kdenney wants to merge 1 commit into
mainfrom
billing/pm-38393/disable-self-host-premium-check-flag
Open

[PM-38393]: add debug-disable-self-host-premium-check feature flag#7805
kdenney wants to merge 1 commit into
mainfrom
billing/pm-38393/disable-self-host-premium-check-flag

Conversation

@kdenney

@kdenney kdenney commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38393

📔 Objective

Registers the QA flag that lets browser/desktop clients take the Stripe premium checkout branch against a self-hosted-region client.

@kdenney
feat: add debug-disable-self-host-premium-check feature flag
fa4fb66 
Registers the QA flag that lets browser/desktop clients take the Stripe
premium checkout branch against a self-hosted-region client. Delivered to
clients automatically via FeatureFlagKeys.GetAllKeys(). Default off.
@kdenney kdenney requested review from a team and connerbw and removed request for a team June 11, 2026 20:01
@github-actions

github-actions Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single feature flag constant, DebugDisableSelfHostPremiumCheck, to the Billing Team section of FeatureFlagKeys in src/Core/Constants.cs. The change is a one-line addition with no server-side consumer, matching the established pattern for client-only feature flags in this file (for example, the neighboring PM34515_BrowserDesktopCheckout). The flag string debug-disable-self-host-premium-check correctly registers the QA toggle the browser/desktop clients will consume.

Code Review Details

No findings.

@sonarqubecloud

sonarqubecloud Bot commented Jun 11, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.15%. Comparing base (6d60c28) to head (fa4fb66).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7805   +/-   ##
=======================================
  Coverage   61.15%   61.15%           
=======================================
  Files        2175     2175           
  Lines       96784    96784           
  Branches     8730     8730           
=======================================
+ Hits        59187    59188    +1     
+ Misses      35487    35486    -1     
  Partials     2110     2110

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connerbw connerbw connerbw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kdenney @connerbw