FINERACT-2635: Add FeignChargesHelper, ChargeRequestBuilders and FeignDelinquencyLifecycleTest#5978
Open
DeathGun44 wants to merge 1 commit into
Conversation
Contributor
Author
|
these test failures are unrelated to my changes |
budaidev
reviewed
Jun 11, 2026
2050897 to
8c743c3
Compare
Contributor
Author
|
this PR only touches files under feign/helpers, feign/modules, feign/tests, and ChargesApiResourceSwagger. the 403 on testLoanCOBPartitioningQuery is not related to my changes. |
…nDelinquencyLifecycleTest Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
8c743c3 to
4ff55c2
Compare
Contributor
Author
|
@budaidev @adamsaghy please take a look when you have a moment |
Contributor
Author
|
unrelated SocketTimeoutException failure |
budaidev
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the RestAssured → Feign migration (PR 3 of the roadmap) to the Charges and Delinquency domains.
Key Changes:
ChargeRequestBuilders: Static typed factories forChargeRequestgeneration.FeignChargesHelper: 14 pure-Feign methods for global (ChargesApi) and client-level (ClientChargesApi) charge management.FeignDelinquencyLifecycleTest: 7 ordered E2E tests verifying delinquency range/bucket CRUD via native Feign.PostChargesRequestinChargesApiResourceSwagger, ensuringChargeRequestgeneration is accurate for PUT requests.createCharge()logic in 3 enricher/report tests with the newchargesHelper.createLoanDisbursementCharge().Note:
LoanChargesApiactions (add/pay/waive on specific loans) and Loan Delinquency actions are deferred to the upcomingFeignLoanHelperPR.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.