Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/transformation/utils/diagnostics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ export const awaitMustBeInAsyncFunction = createErrorDiagnosticFactory(
"Await can only be used inside async functions."
);

export const unsupportedAsyncGenerator = createErrorDiagnosticFactory("Async generator functions are not supported.");

export const unsupportedForAwaitOf = createErrorDiagnosticFactory("'for await...of' loops are not supported.");

export const unsupportedBuiltinOptionalCall = createErrorDiagnosticFactory(
"Optional calls are not supported for builtin or language extension functions."
);
Expand Down
5 changes: 5 additions & 0 deletions src/transformation/visitors/function.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { LuaLibFeature, transformLuaLibFunction } from "../utils/lualib";
import { transformInPrecedingStatementScope } from "../utils/preceding-statements";
import { peekScope, performHoisting, Scope, ScopeType } from "../utils/scope";
import { isFunctionType } from "../utils/typescript";
import { unsupportedAsyncGenerator } from "../utils/diagnostics";
import { isAsyncFunction, wrapInAsyncAwaiter } from "./async-await";
import { transformIdentifier } from "./identifier";
import { transformExpressionBodyToReturnStatement } from "./return";
Expand Down Expand Up @@ -224,6 +225,10 @@ export function transformFunctionToExpression(
): [lua.Expression, Scope] {
assert(node.body);

if (node.asteriskToken && isAsyncFunction(node)) {
context.diagnostics.push(unsupportedAsyncGenerator(node));
}

const type = context.checker.getTypeAtLocation(node);
let functionContext: lua.Identifier | undefined;

Expand Down
5 changes: 5 additions & 0 deletions src/transformation/visitors/loops/for-of.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
import { isRangeFunction, transformRangeStatement } from "../language-extensions/range";
import { transformForInitializer, transformLoopBody } from "./utils";
import { getIterableExtensionKindForNode, IterableExtensionKind } from "../../utils/language-extensions";
import { unsupportedForAwaitOf } from "../../utils/diagnostics";
import { assertNever } from "../../../utils";

function transformForOfArrayStatement(
Expand Down Expand Up @@ -43,6 +44,10 @@ function transformForOfIteratorStatement(
}

export const transformForOfStatement: FunctionVisitor<ts.ForOfStatement> = (node, context) => {
if (node.awaitModifier) {
context.diagnostics.push(unsupportedForAwaitOf(node.awaitModifier));
}

const body = lua.createBlock(transformLoopBody(context, node));

if (ts.isCallExpression(node.expression) && isRangeFunction(context, node.expression)) {
Expand Down
33 changes: 31 additions & 2 deletions test/unit/builtins/async-await.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { ModuleKind, ScriptTarget } from "typescript";
import { LuaTarget } from "../../../src";
import { unsupportedForTargetButOverrideAvailable } from "../../../src/transformation/utils/diagnostics";
import { awaitMustBeInAsyncFunction } from "../../../src/transformation/utils/diagnostics";
import {
awaitMustBeInAsyncFunction,
unsupportedAsyncGenerator,
unsupportedForAwaitOf,
unsupportedForTargetButOverrideAvailable,
} from "../../../src/transformation/utils/diagnostics";
import * as util from "../../util";

const promiseTestLib = `
Expand Down Expand Up @@ -1123,3 +1127,28 @@ describe("try/catch in async function", () => {
.expectToEqual(["finally", "ok"]);
});
});

describe("async generators are unsupported", () => {
test.each([
"async function* gen() { yield 1; }",
"const gen = async function*() { yield 1; };",
"const gen = { async *m() { yield 1; } };",
"class C { async *m() { yield 1; } }",
])("diagnoses %p", source => {
util.testModule`
${source}
export {}
`.expectToHaveDiagnostics([unsupportedAsyncGenerator.code]);
});
});

test("for-await-of is unsupported", () => {
util.testModule`
async function run(items: AsyncIterable<number>) {
for await (const x of items) {
void x;
}
}
export {}
`.expectToHaveDiagnostics([unsupportedForAwaitOf.code]);
});
Loading