Skip to content

apply pilaoda's fix (#1622) #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 1 commit into from
Apr 18, 2026
Merged

apply pilaoda's fix (#1622) #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/transformation/utils/typescript/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,14 @@ export function hasExportEquals(sourceFile: ts.SourceFile): boolean {
* Search up until finding a node satisfying the callback
*/
export function findFirstNodeAbove<T extends ts.Node>(node: ts.Node, callback: (n: ts.Node) => n is T): T | undefined {
let current = node;
// Synthetic nodes (created by pre-transformers like usingTransformer) may have an unset .parent.
// Fall back to ts.getOriginalNode so we can still walk the source-parsed parent chain.
let current = ts.getOriginalNode(node);
while (current.parent) {
if (callback(current.parent)) {
return current.parent;
} else {
current = current.parent;
current = ts.getOriginalNode(current.parent);
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions test/unit/using.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,26 @@ test("await using no extra diagnostics (#1571)", () => {
`.expectToHaveNoDiagnostics();
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1622
test("await-using with nested async arrow that also has await-using (runtime divergence)", () => {
util.testFunction`
const logs: any[] = [];
async function getA(): Promise<AsyncDisposable> {
return { [Symbol.asyncDispose]: async () => {} };
}
async function outer(): Promise<number> {
await using a = await getA();
const inner = async (): Promise<number> => {
await using b = await getA();
return 42;
};
return inner();
}
outer().then(v => logs.push(v));
return logs;
`.expectToEqual([42]);
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1584
test("works with disposable classes (#1584)", () => {
util.testFunction`
Expand Down
Loading