fix await inside catch/finally in async try (#1659)#1709
Merged
Perryvw merged 3 commits intoApr 18, 2026
Merged
Conversation
Perryvw
reviewed
Apr 16, 2026
| await failing(); | ||
| } catch (e) { | ||
| log("catch"); | ||
| const a = await Promise.resolve(true); |
Member
There was a problem hiding this comment.
Could you add a test where this promise is not instantly resolved, and its return value is returned to run? Something like:
try {
await failing();
return "succeeded";
} catch (e) {
return await somePromiseResolvedLater();
}and then resolving the promise after rejecting the first one
Contributor
Author
There was a problem hiding this comment.
Reconciles with TypeScriptToLua#1707 (return/break/continue inside try in async). The merged transformAsyncTry wraps catch and finally in __TS__AsyncAwaiter (so await works inside them) and chains them via reassignment to ____try before the final __TS__Await, while preserving the new hasReturn/hasBreak/hasContinue flag tracking and post-checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1659
__TS__AsyncAwaitersoawaitworks inside them.catch()before.finally()) and wire up the full chain before awaiting.