Conversation
|
LGTM modulo module resolution comments. Awaiting CI but unit tests on my local branch also passed, including after resolving merge conflicts with master. SKimmed other transformer changes but test suite covers so comfortable approving. |
| }` | ||
| ) | ||
| .setOptions({ noResolvePaths: ["ignore*"] }) | ||
| .debug() |
There was a problem hiding this comment.
| .debug() |
| const resolvedPath = this.formatPathToFile(dependencyPath, requiringFile); | ||
| const fileFromPath = this.getFileFromPath(resolvedPath); | ||
| if (fileFromPath) return fileFromPath; | ||
|
|
||
| if (this.options.paths && this.options.baseUrl) { | ||
| if (this.options.paths) { |
There was a problem hiding this comment.
Ordering diverges from TS 6: project file lookup (like a sibling file) can win over a paths-mapped target.
Ref: https://www.typescriptlang.org/docs/handbook/modules/reference.html#paths
TypeScript offers a way to override the compiler’s module resolution for bare specifiers with the
pathscompiler option.
Minimal failing repro at RealColdFry/TypeScriptToLua@e43097e with CI test result
There was a problem hiding this comment.
Actually, it's not clear to me that this is a TS 6.0 change from the release notes. I suppose paths without baseUrl now works so this might get exercised more, but can probably ignore / can be added separately.
| }); | ||
|
|
||
| test("can ignore specific files with glob pattern", () => { | ||
| test.only("can ignore specific files with glob pattern", () => { |
There was a problem hiding this comment.
| test.only("can ignore specific files with glob pattern", () => { | |
| test("can ignore specific files with glob pattern", () => { |
50 failing tests remaining, they still need some careful looking into.
Took many test fixes from #1701, all ones I'd be willing to merge. Might be more in there for remaining failing tests, but ran out of time for now.