Scripts/Westfall: Implement Quest: "Lou's Parting Thoughts"#31855
Open
Naddley wants to merge 8 commits into
Open
Scripts/Westfall: Implement Quest: "Lou's Parting Thoughts"#31855Naddley wants to merge 8 commits into
Naddley wants to merge 8 commits into
Conversation
Co-Authored-By: funjoker <846960+funjoker@users.noreply.github.com>
Contributor
|
@Naddley regarding the announcement text... i saw the same issue, perhaps a core issue but creature_text type 41 (Boss emote) works for me there. |
stevebone
reviewed
May 23, 2026
Contributor
|
For the group cast quest credit, on live blizz does not care whether the player and group kills the last thug... credit is provided to whoever was on Threatlist/in range of the last thug I think... |
stevebone
reviewed
May 23, 2026
Nyr97
reviewed
May 24, 2026
Nyr97
reviewed
May 24, 2026
Nyr97
reviewed
May 24, 2026
Nyr97
reviewed
May 24, 2026
| case Events::LousPartingThoughts::SummonThugs: | ||
| for (uint8 i = 0; i < 4; i++) | ||
| { | ||
| _summons[i] = me->SummonCreature(Creatures::Thug, ThugPos[i], TEMPSUMMON_CORPSE_TIMED_DESPAWN, 60s)->GetGUID(); |
Contributor
There was a problem hiding this comment.
if the summon path fails for whatever reason, the pointer gets null, you access it through GetGUID and we have a crash here, someone confirm
Contributor
|
Few things I spotted:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
None
Tests performed:
build, tested ingame
Known issues and TODO list: (add/remove lines as needed)