Implement ladder (Pumpkin-MC#1056)

hthug06 · web-flow · commit 4b7d9e0fd554 · 2025-07-28T20:32:24.000+02:00
* feat: add ladder placement

* fix: delete .clone()

* all good
diff --git a/pumpkin/src/block/blocks/ladder.rs b/pumpkin/src/block/blocks/ladder.rs
@@ -0,0 +1,85 @@
+use crate::block::pumpkin_block::{
+    CanPlaceAtArgs, GetStateForNeighborUpdateArgs, OnPlaceArgs, OnScheduledTickArgs, PumpkinBlock,
+};
+use crate::world::World;
+use async_trait::async_trait;
+use pumpkin_data::BlockDirection;
+use pumpkin_data::block_properties::HorizontalFacing;
+use pumpkin_data::block_properties::{BlockProperties, LadderLikeProperties};
+use pumpkin_macros::pumpkin_block;
+use pumpkin_util::math::position::BlockPos;
+use pumpkin_world::BlockStateId;
+use pumpkin_world::tick::TickPriority;
+use pumpkin_world::world::BlockFlags;
+
+#[pumpkin_block("minecraft:ladder")]
+pub struct LadderBlock;
+
+#[async_trait]
+impl PumpkinBlock for LadderBlock {
+    async fn on_place(&self, args: OnPlaceArgs<'_>) -> BlockStateId {
+        let mut props = LadderLikeProperties::default(args.block);
+        props.facing = args.direction.opposite().to_cardinal_direction();
+        props.to_state_id(args.block)
+    }
+    async fn can_place_at(&self, args: CanPlaceAtArgs<'_>) -> bool {
+        args.block_accessor
+            .get_block_state(&args.use_item_on.unwrap().position)
+            .await
+            .is_side_solid(args.direction.opposite())
+            && args.direction.is_horizontal()
+    }
+
+    async fn get_state_for_neighbor_update(
+        &self,
+        args: GetStateForNeighborUpdateArgs<'_>,
+    ) -> BlockStateId {
+        if !can_place_at(args.world, args.position).await {
+            args.world
+                .schedule_block_tick(args.block, *args.position, 1, TickPriority::Normal)
+                .await;
+        }
+        args.state_id
+    }
+
+    async fn on_scheduled_tick(&self, args: OnScheduledTickArgs<'_>) {
+        if !can_place_at(args.world, args.position).await {
+            args.world
+                .break_block(args.position, None, BlockFlags::empty())
+                .await;
+        }
+    }
+}
+
+async fn can_place_at(world: &World, position: &BlockPos) -> bool {
+    let props = LadderLikeProperties::from_state_id(
+        world.get_block_state_id(position).await,
+        world.get_block(position).await,
+    );
+    let pos;
+    let direction;
+    match props.r#facing {
+        HorizontalFacing::North => {
+            pos = position.add(0, 0, 1);
+            direction = BlockDirection::North;
+        }
+        HorizontalFacing::South => {
+            pos = position.add(0, 0, -1);
+            direction = BlockDirection::South;
+        }
+        HorizontalFacing::West => {
+            pos = position.add(1, 0, 0);
+            direction = BlockDirection::West;
+        }
+        HorizontalFacing::East => {
+            pos = position.add(-1, 0, 0);
+            direction = BlockDirection::East;
+        }
+    }
+
+    world
+        .get_block_state(&pos)
+        .await
+        .is_side_solid(direction.opposite())
+        && direction.is_horizontal()
+}
diff --git a/pumpkin/src/block/blocks/mod.rs b/pumpkin/src/block/blocks/mod.rs
@@ -28,6 +28,7 @@ pub mod glazed_terracotta;
 pub mod grindstone;
 pub mod iron_bars;
 pub mod jukebox;
+pub mod ladder;
 pub mod logs;
 pub mod nether_portal;
 pub mod note;
diff --git a/pumpkin/src/block/mod.rs b/pumpkin/src/block/mod.rs
@@ -96,6 +96,7 @@ use crate::block::blocks::redstone::dropper::DropperBlock;
 use crate::block::blocks::blast_furnace::BlastFurnaceBlock;
 use crate::block::blocks::ender_chest::EnderChestBlock;
 use crate::block::blocks::hopper::HopperBlock;
+use crate::block::blocks::ladder::LadderBlock;
 use crate::block::blocks::lectern::LecternBlock;
 use crate::block::blocks::shulker_box::ShulkerBoxBlock;
 use crate::block::blocks::skull_block::SkullBlock;
@@ -219,6 +220,7 @@ pub fn default_registry() -> Arc<BlockRegistry> {
     manager.register(ShulkerBoxBlock);
     manager.register(DropperBlock);
     manager.register(DispenserBlock);
+    manager.register(LadderBlock);
 
     // Rails
     manager.register(RailBlock);
