Skip to content

Add view single document and surrounding documents#6831

Merged
lucianogorza merged 12 commits into
4.9.0from
feat/6825-add-view-document-discover
Jul 26, 2024
Merged

Add view single document and surrounding documents#6831
lucianogorza merged 12 commits into
4.9.0from
feat/6825-add-view-document-discover

Conversation

@Machi3mfl

@Machi3mfl Machi3mfl commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Description

This PR adds the view single document and surrounding documents button in flyout details

Closes #6825

Evidence

Screenshot 2024-07-16 at 15 28 57

Test

Check the new view document button in Threat Hunting Dashboard

Screen.Recording.2024-07-16.at.15.23.13.mov

Check the new view document button in Events tab

Screen.Recording.2024-07-16.at.15.23.50.mov

Check the new view document button in Panel tab (GitHub and Office365)

Screen.Recording.2024-07-16.at.15.22.25.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl linked an issue Jul 16, 2024 that may be closed by this pull request
Add view single document and surrounding documents buttons #6825
Closed
@JuanGarriuz JuanGarriuz self-requested a review July 18, 2024 08:16
JuanGarriuz
JuanGarriuz previously requested changes Jul 18, 2024
View reviewed changes

@JuanGarriuz JuanGarriuz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image
image

When I apply a filter incorrectly, I still get results and two alert messages appear.

image

The filters have not been applied correctly in this search.

image

In the filter manager, there are some functions that I don't know what they are used for, such as enable all, pin, and unpin all, etc.

image

@Machi3mfl

Machi3mfl commented Jul 22, 2024

Copy link
Copy Markdown
Contributor Author

Test

image image

When I apply a filter incorrectly, I still get results and two alert messages appear.

image

The filters have not been applied correctly in this search.

image

In the filter manager, there are some functions that I don't know what they are used for, such as enable all, pin, and unpin all, etc.

image

@JuanGarriuz, Thanks for your review. That issue does not belong to our scope because it is the OSD Discover.

@yenienserrano

yenienserrano commented Jul 22, 2024

Copy link
Copy Markdown
Member

Test: 🟢

image image image image

yenienserrano
yenienserrano reviewed Jul 22, 2024
View reviewed changes
Comment thread plugins/main/public/components/common/wazuh-discover/components/doc-details-header.tsx Outdated
Comment thread plugins/main/public/components/common/wazuh-discover/components/doc-details-header.tsx Outdated
Comment thread plugins/main/public/components/common/wazuh-data-grid/wz-data-grid.tsx Outdated
Comment thread plugins/main/public/components/common/wazuh-discover/wz-discover.tsx Outdated
Comment thread plugins/main/public/components/overview/threat-hunting/dashboard/dashboard.tsx Outdated
Comment thread plugins/main/public/components/overview/threat-hunting/dashboard/dashboard.tsx Outdated
yenienserrano
yenienserrano previously approved these changes Jul 24, 2024
View reviewed changes
@lucianogorza lucianogorza self-requested a review July 24, 2024 16:12
lucianogorza
lucianogorza previously approved these changes Jul 24, 2024
View reviewed changes

@lucianogorza lucianogorza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

view_buttons.webm

yenienserrano
yenienserrano previously approved these changes Jul 24, 2024
View reviewed changes
@Machi3mfl Machi3mfl dismissed stale reviews from yenienserrano and lucianogorza via 56d70f2 July 25, 2024 18:05
@github-actions

github-actions Bot commented Jul 26, 2024

Copy link
Copy Markdown
Contributor
Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions

github-actions Bot commented Jul 26, 2024

Copy link
Copy Markdown
Contributor
Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions

github-actions Bot commented Jul 26, 2024

Copy link
Copy Markdown
Contributor
Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3989 / 29248 )
Branches 9.1% ( 1744 / 19157 )
Functions 13.36% ( 943 / 7058 )
Lines 13.82% ( 3886 / 28112 )

lucianogorza
lucianogorza approved these changes Jul 26, 2024
View reviewed changes

@lucianogorza lucianogorza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucianogorza lucianogorza dismissed JuanGarriuz’s stale review July 26, 2024 17:58

That issue does not belong to our scope because it is the OSD Discover.

@lucianogorza lucianogorza merged commit 1b3b815 into 4.9.0 Jul 26, 2024
@lucianogorza lucianogorza deleted the feat/6825-add-view-document-discover branch July 26, 2024 20:03
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yenienserrano yenienserrano yenienserrano left review comments

+2 more reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Machi3mfl Machi3mfl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add view single document and surrounding documents buttons

4 participants

@Machi3mfl @yenienserrano @lucianogorza @JuanGarriuz