Skip to content

Remove management AngularJS controllers#6555

Merged
asteriscos merged 10 commits into
4.9.0from
feat/6549-remove-angularjs-controller-management
Apr 26, 2024
Merged

Remove management AngularJS controllers#6555
asteriscos merged 10 commits into
4.9.0from
feat/6549-remove-angularjs-controller-management

Conversation

@Desvelao

@Desvelao Desvelao commented Mar 26, 2024

Copy link
Copy Markdown
Member

Description

This pull request removes the tools and dev tools AngularJS controllers.

Changes:

  • Remove AngularJS controller of Management
    • Remove deprecated listeners
    • Remove deprecated methods
    • Remove logtestProps from some components that were passed from the
      AngularJS controller
      • Move some methods to ReactJS
  • Create router to manage the view to display
  • Change button to render the Ruleset Test or Decoders Test to use a
    button that opens a flyout.
  • Remove the flyout components in the Logtest component

Warning

This pull request depends on #6532.

Issues Resolved

#6549

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the Server management > Ruleset Test is rendered correctly
Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test
Ensure the Server Management > Groups displays the view
Ensure the Server Management > Status displays the view
Ensure the Server Management > Cluster displays the view
Ensure the Server Management > Statistics displays the view
Ensure the Server Management > Logs displays the view
Ensure the Server Management > Configuration displays the view
Ensure the Server Management > CDB Lists displays the view
Ensure the Server Management > Decoders displays the view
Ensure the Server Management > Rules displays the view
Ensure the Dashboard Management > Reporting displays the view

Details

⚫ Ensure the Server management > Ruleset Test is rendered correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Groups displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Status displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Cluster displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Statistics displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Logs displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Configuration displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > CDB Lists displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Decoders displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Server Management > Rules displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Ensure the Dashboard Management > Reporting displays the view

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

- Remove AngularJS controller of Management
  - Remove deprecated listeners
  - Remove deprecated methods
  - Remove logtestProps from some components that were passed from the
    AngularJS controller
  - Move some methods to ReactJS
- Create router to manage the view to display
- Change button to render the Ruleset Test or Decoders Test to use a
  button that opens a flyout.
  - Remove the flyout components in the Logtest component
@Desvelao Desvelao self-assigned this Mar 26, 2024
@Desvelao Desvelao changed the title Remove management^CngularJS controllers Remove management AngularJS controllers Mar 26, 2024
@Desvelao Desvelao linked an issue Mar 26, 2024 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Contributor
Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions

Copy link
Copy Markdown
Contributor
Wazuh Core plugin code coverage (Jest) test % values
Statements 28.94% ( 286 / 988 )
Branches 26.22% ( 107 / 408 )
Functions 26.87% ( 86 / 320 )
Lines 28.68% ( 278 / 969 )

@github-actions

Copy link
Copy Markdown
Contributor
Main plugin code coverage (Jest) test % values
Statements 12.19% ( 4205 / 34485 )
Branches 7.83% ( 1774 / 22642 )
Functions 10.82% ( 887 / 8196 )
Lines 12.38% ( 4094 / 33052 )

@Desvelao Desvelao marked this pull request as ready for review April 23, 2024 10:58
@JuanGarriuz JuanGarriuz self-requested a review April 23, 2024 11:51
@JuanGarriuz

JuanGarriuz commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test 🟢
Ensure the Server Management > Groups displays the view 🟢
Ensure the Server Management > Status displays the view 🟢
Ensure the Server Management > Cluster displays the view 🟢
Ensure the Server Management > Statistics displays the view 🟢
Ensure the Server Management > Logs displays the view 🟢
Ensure the Server Management > Configuration displays the view 🟢
Ensure the Server Management > CDB Lists displays the view 🟢
Ensure the Server Management > Decoders displays the view 🟢
Ensure the Server Management > Rules displays the view 🟢
Ensure the Server Management > Ruleset Test displays the view 🟢
Ensure the Dashboard Management > Reporting displays the view 🟢

Details

🟢 Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Groups displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Status displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Cluster displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Statistics displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Logs displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Configuration displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > CDB Lists displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Decoders displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Rules displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Ruleset Test displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Dashboard Management > Reporting displays the view

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

JuanGarriuz
JuanGarriuz previously approved these changes Apr 24, 2024

@JuanGarriuz JuanGarriuz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@lucianogorza lucianogorza self-requested a review April 25, 2024 20:12
@lucianogorza

lucianogorza commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

CR 🟢

UI 🟢

Test Chrome Firefox Safari
Ensure the Server management > Ruleset Test is rendered correctly 🟢
Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test 🟢
Ensure the Server Management > Groups displays the view 🟢
Ensure the Server Management > Status displays the view 🟢
Ensure the Server Management > Cluster displays the view 🟢
Ensure the Server Management > Statistics displays the view 🟢
Ensure the Server Management > Logs displays the view 🟢
Ensure the Server Management > Settings displays the view 🟢
Ensure the Server Management > CDB Lists displays the view 🟢
Ensure the Server Management > Decoders displays the view 🟢
Ensure the Server Management > Rules displays the view 🟢
Ensure the Dashboard Management > Reporting displays the view 🟢

Details

🟢 Ensure the Server management > Ruleset Test is rendered correctly

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Ruleset Test button on Decoders/Rules > Add new file opens a flyout with the content of Ruleset Test

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Groups displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Status displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Cluster displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Statistics displays the view

image

image

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Logs displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Settings displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > CDB Lists displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Decoders displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Server Management > Rules displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Ensure the Dashboard Management > Reporting displays the view

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

…o feat/6549-remove-angularjs-controller-management

@lucianogorza lucianogorza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos merged commit 98c64df into 4.9.0 Apr 26, 2024
@asteriscos asteriscos deleted the feat/6549-remove-angularjs-controller-management branch April 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove discover] Refactor AngularJS of management

4 participants