Skip to content

Fix view rule alert link#6553

Merged
asteriscos merged 2 commits into
4.8.0from
fix/view-rule-alert-link-6551
Mar 26, 2024
Merged

Fix view rule alert link#6553
asteriscos merged 2 commits into
4.8.0from
fix/view-rule-alert-link-6551

Conversation

@asteriscos

@asteriscos asteriscos commented Mar 26, 2024

Copy link
Copy Markdown
Member

Description

This pull request fixes the path of the "View alerts of this rule" so it pre-filters the rule ID in the Threat hunting view.

Issues Resolved

Closes #6551

Evidence

Link:
image

Applied filter:
image

Test

  • Go to Server management -> Rules
  • Click on a rule row to display de details flyout
  • Click on the top right link "View alerts of this rule"
  • Check it opens a new tab in Threat hunting with the rule ID pre-applied filter

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 26, 2024
@asteriscos asteriscos linked an issue Mar 26, 2024 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Contributor
Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions

Copy link
Copy Markdown
Contributor
Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions

Copy link
Copy Markdown
Contributor
Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

@JuanGarriuz JuanGarriuz self-requested a review March 26, 2024 11:04
@JuanGarriuz

Copy link
Copy Markdown
Contributor

Test

Evidence

image
image

@JuanGarriuz JuanGarriuz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Desvelao

Copy link
Copy Markdown
Member

Test 🟢

image

@Desvelao Desvelao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit 94a219a into 4.8.0 Mar 26, 2024
@asteriscos asteriscos deleted the fix/view-rule-alert-link-6551 branch March 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View alerts of this rule link is not working

3 participants