Skip to content

Avoid usage of deployment variables on upgrade#15262

Merged
alberpilot merged 3 commits into
4.3from
15245-wpk-upgrade-installerscripts
Nov 4, 2022
Merged

Avoid usage of deployment variables on upgrade#15262
alberpilot merged 3 commits into
4.3from
15245-wpk-upgrade-installerscripts

Conversation

@DFolchA

@DFolchA DFolchA commented Oct 31, 2022

Copy link
Copy Markdown
Contributor
Related issue
#15245

Description

This PR modifies the conditions to launch the CustomAction_InstallerScripts and SetCustomActionDataValue actions in the WXS so they are not launched when upgrading the package.

Configuration options

Logs/Alerts example

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation
  • Package installation
  • Source upgrade
  • Package upgrade
  • Review logs syntax and correct language
  • QA templates contemplate the added capabilities
  • Memory tests for Linux
    • Scan-build report
    • Coverity
    • Valgrind (memcheck and descriptor leaks check)
    • Dr. Memory
    • AddressSanitizer
  • Memory tests for Windows
    • Scan-build report
    • Coverity
    • Dr. Memory
  • Memory tests for macOS
    • Scan-build report
    • Leaks
    • AddressSanitizer
  • Retrocompatibility with older Wazuh versions
  • Working on cluster environments
  • Configuration on demand reports new parameters
  • The data flow works as expected (agent-manager-api-app)
  • Added unit tests (for new features)
  • Stress test for affected components
  • Decoder/Rule tests
    • Added unit testing files ".ini"
    • runtests.py executed without errors

@DFolchA DFolchA requested review from alberpilot and okynos October 31, 2022 09:23
@DFolchA DFolchA self-assigned this Oct 31, 2022
@DFolchA DFolchA changed the title Change CustomAction conditions Avoid usage of deployment variables on upgrade Oct 31, 2022
okynos
okynos previously approved these changes Oct 31, 2022
alberpilot
alberpilot previously approved these changes Oct 31, 2022

@alberpilot alberpilot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DFolchA DFolchA dismissed stale reviews from alberpilot and okynos via cf6db3c November 3, 2022 15:46

@jmv74211 jmv74211 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants