src/utils/fs.ts (2)

6-22: ⚡ Quick win

Verify the dynamic import pattern efficiency.

The fsPromiseModule promise is created once and awaited on every method call. While this works correctly (promises can be awaited multiple times), it adds overhead. Consider storing the resolved module instead.

♻️ Suggested optimization

 function createNodeFs(): UnpluginContextFs {
-  const fsPromiseModule = import('node:fs/promises')
+  let fsPromise: Promise<typeof import('node:fs/promises')> | undefined
   return {
     readFile: async (path, options) => {
-      const fs = await fsPromiseModule
+      fsPromise ??= import('node:fs/promises')
+      const fs = await fsPromise
       return fs.readFile(path, options)
     },
     stat: async (path, options) => {
-      const fs = await fsPromiseModule
+      fsPromise ??= import('node:fs/promises')
+      const fs = await fsPromise
       return fs.stat(path, options)
     },
     lstat: async (path, options) => {
-      const fs = await fsPromiseModule
+      fsPromise ??= import('node:fs/promises')
+      const fs = await fsPromise
       return fs.lstat(path, options)
     },
   }
 }

Or better, cache the resolved module:

 function createNodeFs(): UnpluginContextFs {
-  const fsPromiseModule = import('node:fs/promises')
+  let fsModule: typeof import('node:fs/promises') | undefined
+  async function getFs() {
+    if (!fsModule) {
+      fsModule = await import('node:fs/promises')
+    }
+    return fsModule
+  }
   return {
     readFile: async (path, options) => {
-      const fs = await fsPromiseModule
+      const fs = await getFs()
       return fs.readFile(path, options)
     },
     stat: async (path, options) => {
-      const fs = await fsPromiseModule
+      const fs = await getFs()
       return fs.stat(path, options)
     },
     lstat: async (path, options) => {
-      const fs = await fsPromiseModule
+      const fs = await getFs()
       return fs.lstat(path, options)
     },
   }
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/utils/fs.ts` around lines 6 - 22, The dynamic import promise
fsPromiseModule in createNodeFs is awaited on every call to readFile/stat/lstat
which adds unnecessary overhead; change the implementation to cache the resolved
module (e.g., keep a local variable like cachedFs or resolvedFs) and on the
first call await fsPromiseModule and store the module, then use the cached
module for subsequent calls in readFile, stat, and lstat to avoid repeated
awaits.

---

28-30: ⚡ Quick win

Type assertions suppress important type checking.

The type assertions (as UnpluginContextFs['readFile']) bypass TypeScript's type checking and could hide incompatibilities between pify's output and the expected UnpluginContextFs interface.

Consider adding runtime validation or using more specific typing from pify.

💡 Alternative approach

Instead of type assertions, explicitly type the pified object:

 export function createBuildContextFs(inputFs?: InputFileSystem | null): UnpluginContextFs {
-  const fs = inputFs ? pify(inputFs) : createNodeFs()
+  const fs = inputFs ? pify(inputFs) as {
+    readFile: (path: PathLike, options?: any) => Promise<string | Uint8Array>
+    stat: (path: PathLike, options?: any) => Promise<Stats>
+    lstat: (path: PathLike, options?: any) => Promise<Stats>
+  } : createNodeFs()
 
   return {
-    readFile: fs.readFile as UnpluginContextFs['readFile'],
-    stat: fs.stat as UnpluginContextFs['stat'],
-    lstat: fs.lstat as UnpluginContextFs['lstat'],
+    readFile: fs.readFile,
+    stat: fs.stat,
+    lstat: fs.lstat,
   }
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/utils/fs.ts` around lines 28 - 30, The current lines use type assertions
(readFile: fs.readFile as UnpluginContextFs['readFile'], stat, lstat) which
silence mismatches between pify(fs) output and the UnpluginContextFs shape;
replace the assertions by explicitly typing the pify call (e.g.
pify<UnpluginContextFs>(fs)) or by creating a typed wrapper that maps and
validates each function (readFile, stat, lstat) to the expected signatures, and
add minimal runtime checks (typeof fn === 'function' and argument/return shape
checks or try/catch) to surface incompatible implementations rather than
suppressing errors with "as". Ensure you update the assignment site where
pify(fs) is produced so the resulting object already conforms to
UnpluginContextFs instead of asserting per-property.

• pnpm-lock.yaml: Language not supported