fix: same text and url#68
Open
Barbapapazes wants to merge 5 commits into
Open
Conversation
Contributor
Author
pi0
reviewed
Jan 9, 2024
| if (url) { | ||
| return match.replace( | ||
| `(${path})`, | ||
| `(${cdnBaseURL}/${path.replace(/^\.\//, "")})`, |
Member
There was a problem hiding this comment.
Can you please double-check if we could fix/improve the regex above? generating new (${path}) seems hacky to replace while haven't tried it locally... Also what is a sample README URL we can test against?
Contributor
Author
There was a problem hiding this comment.
Yes, here some readme where there is the issue: #68 (comment)
Contributor
Author
There was a problem hiding this comment.
I've updated the regexp to simplify code and avoid too many if.
6f6f300 to
ca9be8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
If a link looks like this
[./example](./example), current implementation will return[https://raw.githubusercontent.com/example](./example), which is not the expected behavior.This PR fixes this issue by checking replacing the link but not the text.
we could start adding some using testing to validate utils functions and edge cases
📝 Checklist