fix build issue and tests#333
Open
gitjeff05 wants to merge 1 commit into
Open
Conversation
gitjeff05
commented
Oct 4, 2019
| format: "cjs" | ||
| }); | ||
| }).then(function(bundle) { | ||
| var code = bundle.code; |
Author
There was a problem hiding this comment.
In the newer version of rollup, bundle is an object with member output of type Array. Looking at the new docs for rollup, I decided to go from their example:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled this down and noticed that rollup was quite outdated and tests were not passing. Upon further investigation I found that the
rollup.node.jsscript being called inyarn pretestwas busted and so I fixed that first. Then tests passed.I created a production build with
rollup --configand there were some minor differences with version 3.0.2. Mainly with how functions are declared (i.e., function expressions vs declarations) This package could probably use some more tests.