fix: flaky test_start by waiting for in-flight job re-queue

tobymao · tobymao · commit 70bff9f120fa · 2026-05-21T11:09:16.000-07:00
The in-flight job is re-queued in the worker's CancelledError handler,
which stop() only awaits up to cancellation_hard_deadline_s. For the HTTP
proxy that re-queue crosses the network, so the new QUEUED status can land
just after the worker task returns, causing test_start to read ACTIVE under
CI load. Sleep briefly before refreshing.
diff --git a/tests/test_worker.py b/tests/test_worker.py
@@ -113,6 +113,9 @@ async def test_start(self, _mock_logger: MagicMock) -> None:
         self.assertEqual(job.status, Status.ACTIVE)
         task.cancel()
         await task
+        # the in-flight job is re-queued in the worker's CancelledError
+        # handler, which may land just after the worker task returns
+        await asyncio.sleep(0.1)
         await job.refresh()
         self.assertEqual(job.status, Status.QUEUED)
 
@@ -128,6 +131,7 @@ async def test_start(self, _mock_logger: MagicMock) -> None:
         await self.worker.stop()
         await asyncio.sleep(0.01)
         assert task.done()
+        await asyncio.sleep(0.1)
         await job.refresh()
         self.assertEqual(job.status, Status.QUEUED)
 
