Correctly free DTrace resources.#26
Merged
tmetsch merged 1 commit intoFeb 15, 2022
Merged
Conversation
Cython's cdef attributes are not regular class attributes as in Python. hasattr(object, name) always returns False for a cdef attribute corresponding to name. Instead, we should simply check a pointer's value. I couldn't confirm it in any documentation but, based on examples I found and my experiments, it seems that a cdef pointer is always initially set to NULL, at least when declared as a class attribute.
Owner
|
Thanks @kwitaszczyk let me check this stuff and I'll merge this & prep for a new release asap. |
Owner
|
Now released as v0.0.14. Thanks again! Beer on me once we meet (y) |
Contributor
Author
|
Thank you, @tmetsch, for a quick response! I'm up for the beer some day. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cython's cdef attributes are not regular class attributes as in Python.
hasattr(object, name) always returns False for a cdef attribute
corresponding to name.
Instead, we should simply check a pointer's value. I couldn't confirm
it in any documentation but, based on examples I found and my
experiments, it seems that a cdef pointer is always initially set to
NULL, at least when declared as a class attribute.