Repository navigation
Conversation
Unquoted RANK is reserved, so slim write-back inserts failed with a syntax error and the vocab lookup returned 408.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UAT smoke of #21 (
2.1.1-245/497c987) returned HTTP 408 with an empty body for enriched misses such asserendipityandpetrichor.Hibernate sent
insert into phonetic_question (..., RANK, WORD) values (...). MySQL 8.0.32 treats bareRANKas a reserved word, so the insert failed withSQLSyntaxErrorExceptionnear'RANK,WORD) values ('. That exception is anInvalidDataAccessResourceUsageException, whichinsertIfAbsentdoes not catch, andVocabPracticeControllermaps it to 408. No rank-0 rows were written. Bank hits such asapplestill worked because selected columns are table-qualified.@Column(name = "\"RANK\"")makes the MySQL dialect emit`RANK`on insert and update. Other columns stay unquoted. No schema job.Write-back rules are unchanged: true miss only, both IPA and pronunciation URL, rank 0, picture hide left as-is.
Tests
./gradlew testis green.PhoneticQuestionMysqlRankSqlTestrenders insert and update with the MySQL dialect and fails ifRANKis unquoted. H2 accepted the old SQL, which is why the original suite missed this.PhoneticQuestionWriteBackTestandPhoneticQuestionServiceTeststill cover the insert path.Not deployed.