Skip to content

Write slim IPA and pronunciation URL back on vocab miss #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thcathy merged 4 commits into from
Nov 4, 2026
+312 −45
Merged

Write slim IPA and pronunciation URL back on vocab miss #21

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f6d004
Write slim IPA and audio URL back on a vocab database miss.
thcathy Nov 3, 2026
618d257
ci: retrigger Build feature branches for PR #21
thcathy Nov 3, 2026
d867a62
Drop the startup job that creates the phonetic_question WORD constraint.
thcathy Nov 3, 2026
957b13f
Rename the enriched-question insert.
thcathy Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename the enriched-question insert. 
writeBackSlimQuestion is now persistEnrichedQuestion.
  • Loading branch information
@thcathy
thcathy committed Nov 4, 2026
commit 957b13f2855772ff2764fd9c4cf77744fbe36376
6 changes: 3 additions & 3 deletions src/main/java/com/esl/service/PhoneticQuestionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ public PhoneticQuestion buildQuestionByWebAPI(String word) {
question.setPicsFullPaths(new String[] { "" });

fillQuestionByDictionaryResult(question, webService.queryDictionary(word).join());
writeBackSlimQuestion(question);
persistEnrichedQuestion(question);
return question;
}

private void writeBackSlimQuestion(PhoneticQuestion question) {
private void persistEnrichedQuestion(PhoneticQuestion question) {
if (!question.enriched()) {
return;
}
Expand All @@ -55,7 +55,7 @@ private void writeBackSlimQuestion(PhoneticQuestion question) {
try {
phoneticQuestionDAO.insertIfAbsent(question);
} catch (DataIntegrityViolationException e) {
log.info("Skipped slim phonetic_question write-back for '{}': {}",
log.info("Skipped phonetic_question insert for '{}': {}",
question.getWord(), e.getMostSpecificCause().getMessage());
}
}
Expand Down