Repository navigation
Add JSUniqueRef for bridging to non-copyable types - #829
MaxDesiatov wants to merge 1 commit into
Conversation
|
cc @sliemeobn |
kateinoigakukun
left a comment
There was a problem hiding this comment.
Can you split PRs into series, one for adding JSUniqueRef, one for supporting @JSClass struct C: ~Copyable? I haven't checked the details of BridgeJS and TS2Swift changes but it seems like containing a lot of the new things.
Also allowing the JSObject -> JSUniqueRef conversion looks like a soundness hole? The opposite conversion (JSUniqueRef -> JSObject) should be allowed, but the "takeover" from JSObject to JSUniqueRef looks wrong because we cannot ban the further JSObject usage after the takeover?
|
@MaxDesiatov I ran a basic naive ElementaryUI port to JSUniqueRef and the performance improvements in the js-framework-benchmark were modest - basically within noise (± 3.5%). I think what could help a lot is skipping the iiuc this is basically what you have brought up before with the equality checking issue, and my testing suggests this would be a real win and worth it. |
A
~Copyable@JSClassstruct stores a noncopyableJSUniqueRef, and generated bindings take these wrappersborrowing. In the newImported objectbenchmarks, creating or returning a noncopyable wrapper takes 15-26% less time than a copyable wrapper onmain.Median ns per iteration:
Arrays of
JSUniqueRef-values are bridged asUniqueArray, which is made conditionally available when using Swift 6.4. No dictionary counterpart is available, those either require users to manually add and bridge usingswift-collectionsdependency that hasUniqueDictionary, or bridging those as usual copyable values backed by copyableDictionary.