Skip to content

Fix NASA Polynomial Tests and CConfig Integration #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guptapratykshh wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Fix NASA Polynomial Tests and CConfig Integration #2705

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
87b3fdc
Fix NASA Polynomial Tests and CConfig Integration
guptapratykshh Jan 14, 2026
238142d
Apply pre-commit style fixes
guptapratykshh Jan 14, 2026
56c0f4d
Refactor NASA polynomials to use CP_POLYCOEFFS and single CP_NASA flag
guptapratykshh Jan 14, 2026
448854f
Apply clang-format fixes
guptapratykshh Jan 14, 2026
8ce89c9
Allow variable number of coeffs for polynomial CP, MU, KT
guptapratykshh Jan 14, 2026
3701aa2
Add NASA polynomial reference citation and improve code clarity with …
guptapratykshh Jan 15, 2026
eca925a
Implement full NASA-9 polynomial format with NASA-7 backward compatib…
guptapratykshh Jan 15, 2026
7fbbf18
Fix NASA polynomial temperature scaling for non-dimensional simulations
guptapratykshh Jan 16, 2026
9a458fe
Merge branch 'develop' into feature/nasa-polynomials-cp-2634
guptapratykshh Jan 16, 2026
0cc637a
Address code review for NASA polynomials logic: use pow and simplify …
guptapratykshh Jan 17, 2026
db284ac
Code cleanup: check linter suggestions
guptapratykshh Jan 17, 2026
a9272db
Merge branch 'develop' into feature/nasa-polynomials-cp-2634
guptapratykshh Jan 17, 2026
9e203c8
Complete NASA-9 model: add entropy, improve AD compatibility and robu…
guptapratykshh Jan 18, 2026
206abcf
Merge branch 'develop' into feature/nasa-polynomials-cp-2634
bigfooted Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow variable number of coeffs for polynomial CP, MU, KT
  • Loading branch information
@guptapratykshh
guptapratykshh committed Jan 14, 2026
commit 8ce89c99128b229b367a106c3d84ad258d512764
6 changes: 3 additions & 3 deletions Common/src/CConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,11 +1333,11 @@ void CConfig::SetConfig_Options() {
/*--- Options related to temperature polynomial coefficients for fluid models. ---*/

/* DESCRIPTION: Definition of the temperature polynomial coefficients for specific heat Cp. */
addDoubleArrayOption("CP_POLYCOEFFS", N_POLY_COEFFS, false, cp_polycoeffs.data());
addDoubleArrayOption("CP_POLYCOEFFS", N_POLY_COEFFS, true, cp_polycoeffs.data());
/* DESCRIPTION: Definition of the temperature polynomial coefficients for specific heat Cp. */
addDoubleArrayOption("MU_POLYCOEFFS", N_POLY_COEFFS, false, mu_polycoeffs.data());
addDoubleArrayOption("MU_POLYCOEFFS", N_POLY_COEFFS, true, mu_polycoeffs.data());
/* DESCRIPTION: Definition of the temperature polynomial coefficients for specific heat Cp. */
addDoubleArrayOption("KT_POLYCOEFFS", N_POLY_COEFFS, false, kt_polycoeffs.data());
addDoubleArrayOption("KT_POLYCOEFFS", N_POLY_COEFFS, true, kt_polycoeffs.data());

/* DESCRIPTION: Flag to use NASA polynomial format for Cp in incompressible ideal gas model. */
addBoolOption("CP_NASA", Cp_NASA_Format, false);
Expand Down