Add remove by query to JSONObject#488
Closed
serngawy wants to merge 3 commits into
Closed
Conversation
Signed-off-by: serngawy <m.elserngawy@gmail.com>
Signed-off-by: serngawy <m.elserngawy@gmail.com>
Signed-off-by: serngawy <m.elserngawy@gmail.com>
Contributor
|
@serngawy , any reason you didn't use the JSONPointer.java for the query path processing? |
johnjaylward
suggested changes
Oct 15, 2019
johnjaylward
left a comment
Contributor
There was a problem hiding this comment.
A few corrections:
- Please try to use the JSONPointer class for the queries. It would make path queries inconsistent to have 2 different implementations (JSONPointer vs this)
- Use JSONException (or a sub class) for exception throws
Author
|
No reason for not using JsonPointer, just simplicity. will take a look. |
Owner
|
Closed for lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.