Add support for Alter View Rename Column in Postgres v13#1228
Merged
Conversation
robins
reviewed
May 24, 2025
| // If this is a view, only allow view-compatible operations | ||
| if (randomTable.isView()) { | ||
| // Remove all table-specific operations for views | ||
| action.removeIf(a -> a != Action.ALTER_VIEW_RENAME_COLUMN); |
Collaborator
There was a problem hiding this comment.
Do we want to create a list of actions (that are only possible on a view) and use that list in this check? That way, if / when we add more view-only actions, we wouldn't miss them here (and line 112 below).
Contributor
Author
There was a problem hiding this comment.
That's right, I will add a list only for view actions and use it here, thanks for the suggestion
mrigger
reviewed
May 27, 2025
mrigger
left a comment
Contributor
There was a problem hiding this comment.
Almost looks good to me. It seems the FORCE_PARALLEL_MODE change might have been accidental?
| JOIN_COLLAPSE_LIMIT("join_collapse_limit", (r) -> r.getInteger(1, Integer.MAX_VALUE)), | ||
| PARALLEL_LEADER_PARTICIPATION("parallel_leader_participation", (r) -> Randomly.fromOptions(1, 0)), | ||
| FORCE_PARALLEL_MODE("force_parallel_mode", (r) -> Randomly.fromOptions("off", "on", "regress")), | ||
| // FORCE_PARALLEL_MODE("force_parallel_mode", (r) -> Randomly.fromOptions("off", "on", "regress")), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 6. ALTER VIEW RENAME COLUMN in #912
For some reason, FORCE_PARALLEL_MODE will not work locally without commenting out and I suspect it is due to a deprecated issue, so I'm just commenting out for now.