Skip to content

Add support for Alter Statistics and Set Statistics#1227

Merged
mrigger merged 1 commit into
sqlancer:mainfrom
yaojiejia:psql_v13
Jun 3, 2025
Merged

Add support for Alter Statistics and Set Statistics#1227
mrigger merged 1 commit into
sqlancer:mainfrom
yaojiejia:psql_v13

Conversation

@yaojiejia

@yaojiejia yaojiejia commented May 24, 2025

Copy link
Copy Markdown
Contributor

Add support for altering and setting statistics.
Force_parallel_mode is deprecated and has been renamed to debug_parallel_query, therefore, I commented it out.
Read more: https://www.postgresql.org/docs/16/release-16.html
I think postgres has a limitation where "exclude" constraints cannot be used together with partition keys that include expressions, therefore I added some errors handling in the PostgresCommon

Apologize for putting all these in a single issue. Will make sure other issues are separated in the future.

Thanks!

@robins

robins commented May 24, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the PR.

  • Errors for EXCLUDE constraints seem okay to add. That is a technical limitation in postgres for this version, which can be removed / reviewed when a future version's release notes mentions otherwise.

  • "putting all these in a single issue".

    • +1. Regarding both points above, please avoid unrelated changes in the same PR - for simplicity / comprehension.

Lastly, as of now, SQLancer is adding support for features in v13 - #1072 . Also, there is already a PR for force_parallel_mode which is waiting for v16 support.

mrigger
mrigger approved these changes May 27, 2025
View reviewed changes

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @robins, do you think this is ready to be merged as well?

@mrigger mrigger mentioned this pull request May 27, 2025
Merged
@robins

robins commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

LGTM! @robins, do you think this is ready to be merged as well?

The changes are good and the 2 errors seem required too.
The force_parallel_mode is an unnecessary addition here (like the other PR), but otherwise LGTM too.

@yaojiejia - Any chances you're using a non-v13 postgres build to test these?

@yaojiejia

yaojiejia commented May 31, 2025

Copy link
Copy Markdown
Contributor Author

LGTM! @robins, do you think this is ready to be merged as well?

The changes are good and the 2 errors seem required too. The force_parallel_mode is an unnecessary addition here (like the other PR), but otherwise LGTM too.

@yaojiejia - Any chances you're using a non-v13 postgres build to test these?

Yep I think that is the case, I have been using v17 to test these and every time I get the force parallel mode issues. Just revert my local back to 13, so it should be good now.

@mrigger

mrigger commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Yep I think that is the case, I have been using v17 to test these and every time I get the force parallel mode issues. Just revert my local back to 13, so it should be good now.

I think this is still part of the PR? Anyway, I'm merging this for now to not block progress.

@mrigger mrigger merged commit f959252 into sqlancer:main Jun 3, 2025
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrigger mrigger mrigger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaojiejia @robins @mrigger