npm v8 support#44
Merged
Merged
Conversation
This sadly removes support for packageOverrides
Contributor
|
Maybe also remove the travis badge from README |
Contributor
Author
|
Just pushed some changes that greatly simplify the cache building (it no longer has to rewrite the lockfile). Also submitted npm/cacache#114 to be more efficient about putting the npm cache in the nix store. |
balsoft
approved these changes
Jun 1, 2022
balsoft
left a comment
Contributor
There was a problem hiding this comment.
Overall pretty clean, and seems to work! I like it
Member
|
We'll test it in our project, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
passthru.nodeModulesattribute, very useful for debuggingnpm prunesometimes installs packages now :(.@gromakovsky please forward this for review to whoever is using this internally