wrong boolean expression#23
Conversation
…ption: OAuth parameters must either be scope or start with 'oauth_')
…ption: OAuth parameters must either be scope or start with 'oauth_')... really now
|
Dude, The bug is actually fixed since this morning on "master". Thanks anyway for the patches and the kind words :D |
|
But I get an exception anyway for scope. the expression becomes true for every key that does not start with "oauth_", also for "scope". |
|
If you use the JAR, yes it will fail. To get the fix you need to download and build from source |
|
i cloned the repo with git, included the package from src/main/java, tried: OAuthService service = new ServiceBuilder() and got the "OAuth parameters must either be scope or start with 'oauth_'" exception. i'm pretty sure that the if becomes true for each key that does not start with "oauth_", but it should be false if it is/starts with "scope", right? not ("scope" startsWith("oauth_")) == true, |
|
Get 1.0.7 It's fixed there. Sorry for the trouble, you were right all the way |
|
there were no trouble ;) |
|
Very glad to hear that :) Hopefully the code was an easy (or at least not very difficult) read. Thanks! |
hi pablo,
there was a wrong boolean expression in OAuthRequest.java:
in checkKey(String key):
(!key.startsWith(OAUTH_PREFIX) || !key.equals(OAuthConstants.SCOPE)
it returns true for all keys that do not contain "oauth_".
btw, nice library - like it.