Skip to content

Actions for testing & coverage #137

Open

Description

@JoshHiles

Description

As a maintainer,
I want testing & coverage ran on PR’s,
So that we are sure the code is ready for release

Acceptance Criteria

  • When a PR is open a action runs
    • Unit tests
    • Coverage
  • The PR status for the unit tests
    • When fails is red & wont allow the PR to be merged
    • When success is green and will allow the PR to be merged
  • The PR Status for coverage
    • When fails is red & wont allow the PR to be merged
    • When success is green and will allow the PR to be merged

Activity

  1. marblekirby commented on Jul 21, 2021

    @marblekirby

    We can add coverlet for code coverage.

    I can create this github action that will run the unit tests and coverage.

  2. marblekirby commented on Jul 22, 2021

    @marblekirby

    Happy to be assigned this

    What i understand that we need:

    • Create new Xunit project on the core-rewrite branch
    • Add new action to run the Xunit tests + coverlet coverage
    • Add new status badge for above action
  3. JoshHiles commented on Jul 22, 2021

    @JoshHiles
    ContributorAuthor

    Happy to be assigned this

    What i understand that we need:

    * Create new Xunit project on the core-rewrite branch
    
    * Add new action to run the Xunit tests + coverlet coverage
    
    * Add new status badge for above action
    

    Sounds good to me, i will create a 3.0.0 branch so you can fork the repo and create PR's against that

  4. marblekirby commented on Jul 22, 2021

    @marblekirby

    grand - do we want to create new project/solution in the core-rewrite/3.0.0 for me to add unit tests.
    And then include in this action a build of that new Scientist.Net project before testing and coverage

  5. JoshHiles commented on Jul 22, 2021

    @JoshHiles
    ContributorAuthor

    I've pushed up branch 3.0.0
    You can remove the code thats already in the scientist folder i forgot i was having a look and pushed it up

  6. marblekirby commented on Jul 22, 2021

    @marblekirby

    sure thank you 👍 👍

  7. marblekirby commented on Jul 22, 2021

    @marblekirby

    forked and removed the existing code, installed latest coverlet and XUnit. Will create github action and get PR up for this tomorrow.

  8. added a commit that references this issue on Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions