docs(how-to/data-strategy): fix broken links#15111
Conversation
The "Custom Middleware" and "Custom Handler" sections linked to `../../start/data/route-object`, which resolves outside the `docs/` tree (to a non-existent `start/data/route-object`). One link also had a typo, `daoute-object`. Corrected all three to `../start/data/route-object`, matching the `[loader]`/`[action]` reference definitions already used at the bottom of the same file.
|
Hi @morgan-coded, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates internal documentation links in the data strategy guide so route-object references resolve correctly.
Changes:
- Fix relative link paths to
route-object#handleandroute-object#loadersections. - Correct a typo in a previously broken link target (
daoute-object→route-object).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Let's define a middleware on each route via [`handle`](../start/data/route-object#handle) | ||
| and call middleware sequentially first, then call all | ||
| [`loader`](../../start/data/route-object#loader)s in parallel - providing | ||
| [`loader`](../start/data/route-object#loader)s in parallel - providing |
| ### Custom Handler | ||
|
|
||
| It's also possible you don't even want to define a [`loader`](../../start/daoute-object#loader) | ||
| It's also possible you don't even want to define a [`loader`](../start/data/route-object#loader) |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Thanks! |
The "Custom Middleware" and "Custom Handler" sections of the Data Strategy
guide link to
../../start/data/route-object. Fromdocs/how-to/,../../resolves outside the
docs/tree (to a non-existentstart/data/route-object),so these render as dead links on the docs site. One of them also had a typo in
the path:
daoute-object.This corrects all three inline links to
../start/data/route-object, whichmatches the
[loader]/[action]reference-link definitions already used at thebottom of the same file.
Docs-only change, branched from
mainper CONTRIBUTING. No change file needed(no user-facing API impact).