Add __all__ to __init__.py#696
Merged
Merged
Conversation
lazka
reviewed
Dec 24, 2025
Member
|
Apparently this also makes mypy happy: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport from mutagen._util import MutagenError as MutagenError
from mutagen._file import FileType as FileType, StreamInfo as StreamInfo, File as File
from mutagen._tags import Tags as Tags, Metadata as Metadata, PaddingInfo as PaddingInfonot sure which one I prefer |
Member
|
I guess we use In other places were we don't want to change |
|
This could be co-authored but ok, that's why reviews exist. I'm not trying to be pendantic tho |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #647.
When using mypy in strict mode I am forced to import items from root mutagen namespace as:
If I remove the ignore statement I get this error:
There is another PR relating to this issue: #695
But the tests are failing for that due to some changes made