-
Notifications
You must be signed in to change notification settings - Fork 97
Simplify setup.py? #234
Copy link
Copy link
Closed
Labels
EnhancementNot a bug, but increases or improves in value, quality, desirability, or attractivenessNot a bug, but increases or improves in value, quality, desirability, or attractivenessInfraAll about infrastructure (GitHub Action, project build etc.)All about infrastructure (GitHub Action, project build etc.)QuestionUnclear or open issue subject for debateUnclear or open issue subject for debateRelease_3.x.yOnly for the major release 3Only for the major release 3
Metadata
Metadata
Assignees
Labels
EnhancementNot a bug, but increases or improves in value, quality, desirability, or attractivenessNot a bug, but increases or improves in value, quality, desirability, or attractivenessInfraAll about infrastructure (GitHub Action, project build etc.)All about infrastructure (GitHub Action, project build etc.)QuestionUnclear or open issue subject for debateUnclear or open issue subject for debateRelease_3.x.yOnly for the major release 3Only for the major release 3
Type
Fields
Give feedbackSIze
None yet
Situation
As we saw in issue #224, the
setup.pyscript can be tricky. Usually, asetup.pyscript should describe its metadata, but should avoid any "complicated" command logic.We had this situation already in the past: in issue #148 we discouraged the use of
python setup.py testin documentation.Proposal
I propose to remove the
ToxandCleanclasses in thesetup.pyscript for the following reasons:setup.pyscript should be "as simple as possible".Maybe I miss a good reason, but at the moment, I think they are not really that essential, right?
Questions
@python-semver/reviewers What do you think about this proposal? 😉