Skip to content

Fix/import imp - #917

Closed
dendisuhubdy wants to merge 0 commit into
python-mode:developfrom
dendisuhubdy:fix/import-imp
Closed

dendisuhubdy wants to merge 0 commit into
python-mode:developfrom
dendisuhubdy:fix/import-imp

Conversation

@dendisuhubdy

Copy link
Copy Markdown

Adding changes to address imp deprecated since version 3.4. https://docs.python.org/3/library/imp.html

@diraol

diraol commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

@dendisuhubdy why did you closed the PR? Any special reason?!

@dendisuhubdy

dendisuhubdy commented Jul 5, 2018 •

Copy link
Copy Markdown
Author

@diraol it didn't pass travis-ci build tests, I could reopen it if you want, and I didn't have time to resolve the conflicts (yet).

@dendisuhubdy dendisuhubdy reopened this Jul 5, 2018
@diraol

diraol commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

@dendisuhubdy try rebasing your branch against our develop branch, please! =)

@diraol

diraol commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

@dendisuhubdy did you created this branch based on the master branch?

@dendisuhubdy

Copy link
Copy Markdown
Author

@diraol I think so, I'm doing a reset --hard to the latest commit on the latest commit and rebasing it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants