diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index bfad18a2e..d0c3f71fb 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -421,7 +421,7 @@ jobs: id: coverageAttempt3 if: steps.coverageAttempt2.outcome == 'failure' # Continue even if it failed 3 times... (sheesh! use codecov instead) - continue-on-error: true + continue-on-error: false env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} COVERALLS_FLAG_NAME: ${{ matrix.os }}/${{ matrix.slowtask }} diff --git a/graphblas/tests/test_io.py b/graphblas/tests/test_io.py index bda41759b..671b12bd6 100644 --- a/graphblas/tests/test_io.py +++ b/graphblas/tests/test_io.py @@ -369,7 +369,7 @@ def test_scipy_sparse(): @pytest.mark.skipif("not ak") -@pytest.mark.xfail(reason="Need to investigate test failure") +@pytest.mark.xfail(np.__version__[:5] == "1.25.", reason="awkward bug with numpy 1.25") def test_awkward_roundtrip(): # Vector v = gb.Vector.from_coo([1, 3, 5], [20, 21, -5], size=22) @@ -391,7 +391,7 @@ def test_awkward_roundtrip(): @pytest.mark.skipif("not ak") -@pytest.mark.xfail(reason="Need to investigate test failure") +@pytest.mark.xfail(np.__version__[:5] == "1.25.", reason="awkward bug with numpy 1.25") def test_awkward_iso_roundtrip(): # Vector v = gb.Vector.from_coo([1, 3, 5], [20, 20, 20], size=22) diff --git a/pyproject.toml b/pyproject.toml index ba8ec0095..9e57b8296 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -170,7 +170,7 @@ line_length = 100 [tool.pytest.ini_options] minversion = "6.0" testpaths = "graphblas/tests" -xfail_strict = false # TODO: re-enable this when awkward test failures are fixed +xfail_strict = true addopts = [ "--strict-config", # Force error if config is mispelled "--strict-markers", # Force error if marker is mispelled (must be defined in config)