Skip to content

xfail awkward tests when using numpy 1.25 #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriknw merged 1 commit into from
Jun 23, 2023
Merged

xfail awkward tests when using numpy 1.25 #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_and_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ jobs:
id: coverageAttempt3
if: steps.coverageAttempt2.outcome == 'failure'
# Continue even if it failed 3 times... (sheesh! use codecov instead)
continue-on-error: true
continue-on-error: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_FLAG_NAME: ${{ matrix.os }}/${{ matrix.slowtask }}
Expand Down
4 changes: 2 additions & 2 deletions graphblas/tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ def test_scipy_sparse():


@pytest.mark.skipif("not ak")
@pytest.mark.xfail(reason="Need to investigate test failure")
@pytest.mark.xfail(np.__version__[:5] == "1.25.", reason="awkward bug with numpy 1.25")
def test_awkward_roundtrip():
# Vector
v = gb.Vector.from_coo([1, 3, 5], [20, 21, -5], size=22)
Expand All @@ -391,7 +391,7 @@ def test_awkward_roundtrip():


@pytest.mark.skipif("not ak")
@pytest.mark.xfail(reason="Need to investigate test failure")
@pytest.mark.xfail(np.__version__[:5] == "1.25.", reason="awkward bug with numpy 1.25")
def test_awkward_iso_roundtrip():
# Vector
v = gb.Vector.from_coo([1, 3, 5], [20, 20, 20], size=22)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ line_length = 100
[tool.pytest.ini_options]
minversion = "6.0"
testpaths = "graphblas/tests"
xfail_strict = false # TODO: re-enable this when awkward test failures are fixed
xfail_strict = true
addopts = [
"--strict-config", # Force error if config is mispelled
"--strict-markers", # Force error if marker is mispelled (must be defined in config)
Expand Down