Repository navigation
Allow masks to be combined with | and& - #267
Merged
Merged
Conversation
jim22k
reviewed
Jul 7, 2022
jim22k
approved these changes
Jul 7, 2022
jim22k
left a comment
Member
There was a problem hiding this comment.
The code all looks good, but the comments are technically wrong.
I think the recipe needs to be:
>>> val = Matrix(bool, nrows, ncols)
>>> val(mask1) << True
>>> val(mask2, replace=True) << val
>>> new_mask = val.S
The same recipe should be listed in the comments for `.new()` as well.
Member
Author
|
Updated docstrings. We came up with the same solution, which is a good sign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #234
These recipes are much faster than the equivalent recipes in the docstrings, but they still aren't hyper-optimized (they're only semi-optimized). As with
.new, this is structured so that any recipe can be updated if need arises.Currently, all recipes return structural masks that may be complemented. It's not required for them to be structural--perhaps it would be better if some were value masks.