Repository navigation
Recipe to perform select with a mask (or bool) argument. - #251
Merged
Merged
Conversation
This allows e.g. `A.select(B.S)`.
Member
Author
|
Thanks for the review (and suggestion) Jim, I think this reads pretty nicely. I'm finding our custom-expression handling is actually pretty powerful. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows e.g.
A.select(B.S)andA.select(C < 5).This is enhancement (4) in #234.
This does not yet optimize e.g.
A.select(A < 4)into the suitable select operation, but such an optimization is possible (and would probably be straightforward-ish).Also, we'll want to double-check the recipes regarding masks, accum, etc. I think maybe if there is no mask but there is an accumulator, then we shouldn't use
replace=True.