Skip to content

Have the recorder log errors, which helps with debugging. #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriknw merged 2 commits into from
Sep 30, 2021
Merged

Have the recorder log errors, which helps with debugging. #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
339171e
Have the recorder log errors, which helps with debugging.
eriknw Sep 30, 2021
911b2f2
oops
eriknw Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion grblas/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ def call(cfunc_name, args):
f" - C signature: {sig}\n"
f" - Error: {exc}"
)
rv = check_status(err_code, args)
try:
rv = check_status(err_code, args)
except Exception as exc:
# Record calls that fail for easier debugging
rec = _recorder.get(_prev_recorder)
if rec is not None:
rec.record(cfunc_name, args, exc=exc)
raise
rec = _recorder.get(_prev_recorder)
if rec is not None:
rec.record(cfunc_name, args)
Expand Down
7 changes: 5 additions & 2 deletions grblas/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,13 @@ def __init__(self, *, start=True, max_rows=20):
if start:
self.start()

def record(self, cfunc_name, args):
def record(self, cfunc_name, args, *, exc=None):
if not hasattr(lib, cfunc_name):
cfunc_name = f"GxB_{cfunc_name[4:]}"
self.data.append(f'{cfunc_name}({", ".join(gbstr(x) for x in args)});')
val = f'{cfunc_name}({", ".join(gbstr(x) for x in args)});'
if exc is not None:
val += f" /* ERROR: {type(exc).__name__} */"
self.data.append(val)
base._prev_recorder = self

def record_raw(self, text):
Expand Down
14 changes: 14 additions & 0 deletions grblas/tests/test_recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import grblas as gb
from grblas.exceptions import OutOfMemory
from grblas.formatting import CSS_STYLE


Expand Down Expand Up @@ -138,3 +139,16 @@ def test_record_repr_markdown():
"</details>\n"
"</div>"
)


def test_record_failed_call():
BIG = gb.Vector.new(int, size=2 ** 55)
small = gb.Vector.new(int, size=2 ** 55)
BIG[:] = 1
small[0] = 2
rec = gb.Recorder()
try:
BIG.ewise_add(small).new()
except OutOfMemory:
pass
assert "ERROR: OutOfMemory" in rec.data[-1]